diff options
author | Marc Kleine-Budde <mkl@pengutronix.de> | 2022-07-19 09:22:35 +0200 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2022-07-20 14:03:40 +0100 |
commit | 4ceaa684459d414992acbefb4e4c31f2dfc50641 (patch) | |
tree | 54a3e19fbfdcd51783efbc64c39e5d11642e8bef /drivers/spi/spi-cadence.c | |
parent | 73d5fe046270281a46344e06bf986c607632f7ea (diff) | |
download | lwn-4ceaa684459d414992acbefb4e4c31f2dfc50641.tar.gz lwn-4ceaa684459d414992acbefb4e4c31f2dfc50641.zip |
spi: bcm2835: bcm2835_spi_handle_err(): fix NULL pointer deref for non DMA transfers
In case a IRQ based transfer times out the bcm2835_spi_handle_err()
function is called. Since commit 1513ceee70f2 ("spi: bcm2835: Drop
dma_pending flag") the TX and RX DMA transfers are unconditionally
canceled, leading to NULL pointer derefs if ctlr->dma_tx or
ctlr->dma_rx are not set.
Fix the NULL pointer deref by checking that ctlr->dma_tx and
ctlr->dma_rx are valid pointers before accessing them.
Fixes: 1513ceee70f2 ("spi: bcm2835: Drop dma_pending flag")
Cc: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://lore.kernel.org/r/20220719072234.2782764-1-mkl@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-cadence.c')
0 files changed, 0 insertions, 0 deletions