diff options
| author | David S. Miller <davem@davemloft.net> | 2005-10-03 17:37:27 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-10-03 17:37:27 -0700 |
| commit | fdc657c66678551c7987dc23a78ae1a26251276f (patch) | |
| tree | e8046592965a658370211f4068c1b9cdc5edb33e /drivers/serial | |
| parent | 3115624eda34d0f4e673fc6bcea36b7ad701ee33 (diff) | |
| download | lwn-fdc657c66678551c7987dc23a78ae1a26251276f.tar.gz lwn-fdc657c66678551c7987dc23a78ae1a26251276f.zip | |
[SUNSU]: Fix bogus locking in sunsu_change_mouse_baud()
The lock is not held when calling this function, so we
shouldn't drop then reacquire it.
Based upon a report from Jim MacBaine.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/serial')
| -rw-r--r-- | drivers/serial/sunsu.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/drivers/serial/sunsu.c b/drivers/serial/sunsu.c index 5959e6755a81..656c0e8d160e 100644 --- a/drivers/serial/sunsu.c +++ b/drivers/serial/sunsu.c @@ -518,11 +518,7 @@ static void sunsu_change_mouse_baud(struct uart_sunsu_port *up) quot = up->port.uartclk / (16 * new_baud); - spin_unlock(&up->port.lock); - sunsu_change_speed(&up->port, up->cflag, 0, quot); - - spin_lock(&up->port.lock); } static void receive_kbd_ms_chars(struct uart_sunsu_port *up, struct pt_regs *regs, int is_break) |