summaryrefslogtreecommitdiff
path: root/drivers/scsi
diff options
context:
space:
mode:
authorJesper Juhl <jj@chaosbits.net>2012-04-09 22:51:41 +0200
committerJiri Kosina <jkosina@suse.cz>2012-04-30 13:23:57 +0200
commitcf92549f1c95e0b1fd980828c35416dc2e548d2b (patch)
tree81f1ce47a266daa40150aed8fe78eb1736fd4191 /drivers/scsi
parentee51f4432e375d07c29758e592c8c1ad1a343208 (diff)
downloadlwn-cf92549f1c95e0b1fd980828c35416dc2e548d2b.tar.gz
lwn-cf92549f1c95e0b1fd980828c35416dc2e548d2b.zip
qla2xxx: Remove redundant NULL check before release_firmware() call.
release_firmware() checks for NULL pointers internally so checking before calling it is redundant. Signed-off-by: Jesper Juhl <jj@chaosbits.net> Acked-by: Chad Dupuis <chad.dupuis@qlogic.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/scsi')
-rw-r--r--drivers/scsi/qla2xxx/qla_os.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index a2f999273a5f..91b6fe6000eb 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void)
mutex_lock(&qla_fw_lock);
for (idx = 0; idx < FW_BLOBS; idx++)
- if (qla_fw_blobs[idx].fw)
- release_firmware(qla_fw_blobs[idx].fw);
+ release_firmware(qla_fw_blobs[idx].fw);
mutex_unlock(&qla_fw_lock);
}