diff options
| author | Finn Thain <fthain@telegraphics.com.au> | 2014-11-12 16:11:58 +1100 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-11-20 09:11:08 +0100 |
| commit | 8c32513bd395dc5d382e4883097482567cf8bbc5 (patch) | |
| tree | f603eda2bb0ccf602c88b69e7fb9f6fb6cb947c7 /drivers/scsi/t128.h | |
| parent | 270ac2c290ad8b83c92ceeed07aaf49ec5807851 (diff) | |
| download | lwn-8c32513bd395dc5d382e4883097482567cf8bbc5.tar.gz lwn-8c32513bd395dc5d382e4883097482567cf8bbc5.zip | |
ncr5380: Cleanup host info() methods
If the host->info() method is not set, then host->name is used by default.
For atari_scsi, that is exactly the same text. So remove the redundant
info() method. Keep sun3_scsi.c in line with atari_scsi.
Some NCR5380 drivers return an empty string from the info() method
(arm/cumana_1.c arm/oak.c mac_scsi.c) while other drivers use the default
(dmx3191d dtc.c g_NCR5380.c pas16.c t128.c).
Implement a common info() method to replace a lot of duplicated code which
the various drivers use to announce the same information.
This replaces most of the (deprecated) show_info() output and all of the
NCR5380_print_info() output. This also eliminates a bunch of code in
g_NCR5380 which just duplicates functionality in the core driver.
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/t128.h')
| -rw-r--r-- | drivers/scsi/t128.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/scsi/t128.h b/drivers/scsi/t128.h index 9f06c1851069..806dda75820a 100644 --- a/drivers/scsi/t128.h +++ b/drivers/scsi/t128.h @@ -116,6 +116,7 @@ #define NCR5380_queue_command t128_queue_command #define NCR5380_abort t128_abort #define NCR5380_bus_reset t128_bus_reset +#define NCR5380_info t128_info #define NCR5380_show_info t128_show_info #define NCR5380_write_info t128_write_info |