diff options
| author | Subhash Jadavani <subhashj@codeaurora.org> | 2014-09-25 15:32:20 +0300 |
|---|---|---|
| committer | Christoph Hellwig <hch@lst.de> | 2014-10-01 13:11:08 +0200 |
| commit | 693ad5ba135d40b1379e40e928123681e2aa2c50 (patch) | |
| tree | 6a656a66b3f8786bddaf3c600a7820128a875285 /drivers/scsi/scsi_scan.c | |
| parent | 45341ca3fcacc8720c425e757a627ef81b65b1ee (diff) | |
| download | lwn-693ad5ba135d40b1379e40e928123681e2aa2c50.tar.gz lwn-693ad5ba135d40b1379e40e928123681e2aa2c50.zip | |
scsi: don't add scsi_device if its already visible
If LLD has added scsi device (by calling scsi_add_device) before scheduling
async scsi_scan_host then scsi_finish_async_scan() will end up calling
scsi_sysfs_add_sdev for scsi device which was already added by LLD.
This patch fixes this issue by skipping the call to scsi_sysfs_add_sdev()
if it's already visible to rest of the kernel.
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'drivers/scsi/scsi_scan.c')
| -rw-r--r-- | drivers/scsi/scsi_scan.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index dde0c542e0b1..ba3f1e8d0d57 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c @@ -1756,6 +1756,9 @@ static void scsi_sysfs_add_devices(struct Scsi_Host *shost) /* target removed before the device could be added */ if (sdev->sdev_state == SDEV_DEL) continue; + /* If device is already visible, skip adding it to sysfs */ + if (sdev->is_visible) + continue; if (!scsi_host_scan_allowed(shost) || scsi_sysfs_add_sdev(sdev) != 0) __scsi_remove_device(sdev); |