diff options
| author | Tejun Heo <htejun@gmail.com> | 2005-10-06 11:43:29 +0900 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2005-10-06 05:51:24 -0400 |
| commit | ad6e90f6d0c4243cc35e07e2681a3323af533ce4 (patch) | |
| tree | 3f9af49242301e69b43e1bb151d173f2152cf310 /drivers/scsi/sata_sil24.c | |
| parent | 012e060c95e547eceea4a12c6f58592473bf4011 (diff) | |
| download | lwn-ad6e90f6d0c4243cc35e07e2681a3323af533ce4.tar.gz lwn-ad6e90f6d0c4243cc35e07e2681a3323af533ce4.zip | |
[PATCH] sil24: ignore non-error exception irqs
01_sil24_ignore-non-error-exception-irqs.patch
Do not error-finish commands for non-error exception irqs -
just ignore them. This is taken from Edward's driver.
Signed-off-by: Tejun Heo <htejun@gmail.com>
sata_sil24.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/scsi/sata_sil24.c')
| -rw-r--r-- | drivers/scsi/sata_sil24.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/drivers/scsi/sata_sil24.c b/drivers/scsi/sata_sil24.c index d8a2f5f04e82..571302dc48a3 100644 --- a/drivers/scsi/sata_sil24.c +++ b/drivers/scsi/sata_sil24.c @@ -489,12 +489,21 @@ static void sil24_error_intr(struct ata_port *ap, u32 slot_stat) u32 irq_stat, cmd_err, sstatus, serror; irq_stat = readl(port + PORT_IRQ_STAT); + writel(irq_stat, port + PORT_IRQ_STAT); /* clear irq */ + + if (!(irq_stat & PORT_IRQ_ERROR)) { + /* ignore non-completion, non-error irqs for now */ + printk(KERN_WARNING DRV_NAME + "ata%u: non-error exception irq (irq_stat %x)\n", + ap->id, irq_stat); + return; + } + cmd_err = readl(port + PORT_CMD_ERR); sstatus = readl(port + PORT_SSTATUS); serror = readl(port + PORT_SERROR); /* Clear IRQ/errors */ - writel(irq_stat, port + PORT_IRQ_STAT); if (cmd_err) writel(cmd_err, port + PORT_CMD_ERR); if (serror) |