diff options
| author | Jesper Juhl <jj@chaosbits.net> | 2012-04-09 22:51:36 +0200 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.cz> | 2012-04-30 13:25:43 +0200 |
| commit | 90449e5dee4800721a352af11ae4d65d4a56ba93 (patch) | |
| tree | 654ef6050865cd4da1eee6ecc842873f14a631a9 /drivers/scsi/qla1280.c | |
| parent | 3cc6e78777ae6f577b67e26c76577ef357ac9009 (diff) | |
| download | lwn-90449e5dee4800721a352af11ae4d65d4a56ba93.tar.gz lwn-90449e5dee4800721a352af11ae4d65d4a56ba93.zip | |
qla1280: Remove redundant NULL check before release_firmware() call
release_firmware() checks for NULL pointers internally so checking
before calling the function is redundant.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'drivers/scsi/qla1280.c')
| -rw-r--r-- | drivers/scsi/qla1280.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c index 6c6486f626ee..538230be5cca 100644 --- a/drivers/scsi/qla1280.c +++ b/drivers/scsi/qla1280.c @@ -4473,17 +4473,14 @@ qla1280_exit(void) pci_unregister_driver(&qla1280_pci_driver); /* release any allocated firmware images */ for (i = 0; i < QL_NUM_FW_IMAGES; i++) { - if (qla1280_fw_tbl[i].fw) { - release_firmware(qla1280_fw_tbl[i].fw); - qla1280_fw_tbl[i].fw = NULL; - } + release_firmware(qla1280_fw_tbl[i].fw); + qla1280_fw_tbl[i].fw = NULL; } } module_init(qla1280_init); module_exit(qla1280_exit); - MODULE_AUTHOR("Qlogic & Jes Sorensen"); MODULE_DESCRIPTION("Qlogic ISP SCSI (qla1x80/qla1x160) driver"); MODULE_LICENSE("GPL"); |