diff options
| author | Colin Ian King <colin.king@canonical.com> | 2017-05-03 17:29:01 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2017-05-08 22:16:45 -0400 |
| commit | b77b36cb7272ec5b9fb000e2ff18e947d9586a22 (patch) | |
| tree | a29210bc9f2e20af833b00993196ddd5b83457f2 /drivers/scsi/pmcraid.c | |
| parent | 019c0d66f66a8612bb867caf05e865a4766238a4 (diff) | |
| download | lwn-b77b36cb7272ec5b9fb000e2ff18e947d9586a22.tar.gz lwn-b77b36cb7272ec5b9fb000e2ff18e947d9586a22.zip | |
scsi: pmcraid: remove redundant check to see if request_size is less than zero
The 2nd check to see if request_size is less than zero is redundant
because the first check takes error exit path on this condition. So,
since it is redundant, remove it.
Detected by CoverityScan, CID#146149 ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/pmcraid.c')
| -rw-r--r-- | drivers/scsi/pmcraid.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c index a4aadf5f4dc6..1cc814f1505a 100644 --- a/drivers/scsi/pmcraid.c +++ b/drivers/scsi/pmcraid.c @@ -3770,9 +3770,6 @@ static long pmcraid_ioctl_passthrough( pmcraid_err("couldn't build passthrough ioadls\n"); goto out_free_cmd; } - } else if (request_size < 0) { - rc = -EINVAL; - goto out_free_cmd; } /* If data is being written into the device, copy the data from user |