summaryrefslogtreecommitdiff
path: root/drivers/scsi/mpt3sas/mpt3sas_base.c
diff options
context:
space:
mode:
authorAnatoliy Glagolev <glagolig@gmail.com>2018-12-06 16:48:45 -0700
committerMartin K. Petersen <martin.petersen@oracle.com>2018-12-19 21:26:38 -0500
commit17b18eaa6f59044a5172db7d07149e31ede0f920 (patch)
tree92b58684fc7db8e44f5d103117081a8220fbba7a /drivers/scsi/mpt3sas/mpt3sas_base.c
parent38417468d4f05cfed62fca8f407d2df0cbe3fcc8 (diff)
downloadlwn-17b18eaa6f59044a5172db7d07149e31ede0f920.tar.gz
lwn-17b18eaa6f59044a5172db7d07149e31ede0f920.zip
scsi: qla2xxx: deadlock by configfs_depend_item
The intent of invoking configfs_depend_item in commit 7474f52a82d51 ("tcm_qla2xxx: Perform configfs depend/undepend for base_tpg") was to prevent a physical Fibre Channel port removal when virtual (NPIV) ports announced through that physical port are active. The change does not work as expected: it makes enabled physical port dependent on target configfs subsystem (the port's parent), something the configfs guarantees anyway. Besides, scheduling work in a worker thread and waiting for the work's completion is not really a valid workaround for the requirement not to call configfs_depend_item from a configfs callback: the call occasionally deadlocks. Thus, removing configfs_depend_item calls does not break anything and fixes the deadlock problem. Signed-off-by: Anatoliy Glagolev <glagolig@gmail.com> Acked-by: Himanshu Madhani <hmadhani@marvell.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/mpt3sas/mpt3sas_base.c')
0 files changed, 0 insertions, 0 deletions