diff options
| author | Mike Christie <michaelc@cs.wisc.edu> | 2006-07-24 15:47:39 -0500 |
|---|---|---|
| committer | James Bottomley <jejb@mulgrave.il.steeleye.com> | 2006-07-28 11:49:34 -0500 |
| commit | c8dc1e523b0f1e6dd71cdabd8c7d7587c6dc27f9 (patch) | |
| tree | 466efa148c152f4330c92f02f81bc72e8f395114 /drivers/scsi/iscsi_tcp.h | |
| parent | 9aaa2b4621280b6de1ecfb6dd7cd5cbe59fd1264 (diff) | |
| download | lwn-c8dc1e523b0f1e6dd71cdabd8c7d7587c6dc27f9.tar.gz lwn-c8dc1e523b0f1e6dd71cdabd8c7d7587c6dc27f9.zip | |
[SCSI] iscsi bugfixes: reduce memory allocations
We currently try to allocate a max_recv_data_segment_length
which can be very large (default is 64K), and common uses
are up to 1MB. It is very very difficult to allocte this
much contiguous memory and it turns out we never even use it.
We really only need a couple of pages, so this patch has us
allocates just what we know what we need today.
Later if vendors start adding vendor specific data and
we need to handle large buffers we can do this, but for
the last 4 years we have not seen anyone do this or request
it.
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Diffstat (limited to 'drivers/scsi/iscsi_tcp.h')
| -rw-r--r-- | drivers/scsi/iscsi_tcp.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/scsi/iscsi_tcp.h b/drivers/scsi/iscsi_tcp.h index 808302832e68..6a4ee704e46e 100644 --- a/drivers/scsi/iscsi_tcp.h +++ b/drivers/scsi/iscsi_tcp.h @@ -78,8 +78,6 @@ struct iscsi_tcp_conn { char hdrext[4*sizeof(__u16) + sizeof(__u32)]; int data_copied; - char *data; /* data placeholder */ - int data_size; /* actual recv_dlength */ int stop_stage; /* conn_stop() flag: * * stop to recover, * * stop to terminate */ |