diff options
| author | Benjamin Herrenschmidt <benh@kernel.crashing.org> | 2012-07-30 11:33:05 +1000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-07 08:32:28 -0700 |
| commit | 54ce2fb86f0b78808c7fcc1d581ebbf15ca36e91 (patch) | |
| tree | 6e979c7933a334c89279a11bc4ec2b60e74b7c20 /drivers/scsi/ibmvscsi/ibmvscsi.c | |
| parent | 7d0fcfec4c491eb3c815929be5512ae8d1886553 (diff) | |
| download | lwn-54ce2fb86f0b78808c7fcc1d581ebbf15ca36e91.tar.gz lwn-54ce2fb86f0b78808c7fcc1d581ebbf15ca36e91.zip | |
SCSI: ibmvscsi: Fix host config length field overflow
commit 225c56960fcafeccc2b6304f96cd3f0dbf42a16a upstream.
The length field in the host config packet is only 16-bit long, so
passing it 0x10000 (64K which is our standard PAGE_SIZE) doesn't
work and result in an empty config from the server.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Robert Jennings <rcj@linux.vnet.ibm.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/scsi/ibmvscsi/ibmvscsi.c')
| -rw-r--r-- | drivers/scsi/ibmvscsi/ibmvscsi.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 3a6c4742951e..337e8b33d9aa 100644 --- a/drivers/scsi/ibmvscsi/ibmvscsi.c +++ b/drivers/scsi/ibmvscsi/ibmvscsi.c @@ -1541,6 +1541,9 @@ static int ibmvscsi_do_host_config(struct ibmvscsi_host_data *hostdata, host_config = &evt_struct->iu.mad.host_config; + /* The transport length field is only 16-bit */ + length = min(0xffff, length); + /* Set up a lun reset SRP command */ memset(host_config, 0x00, sizeof(*host_config)); host_config->common.type = VIOSRP_HOST_CONFIG_TYPE; |