diff options
| author | Stephen M. Cameron <scameron@beardog.cce.hp.com> | 2012-01-05 10:15:31 -0600 |
|---|---|---|
| committer | James Bottomley <JBottomley@Parallels.com> | 2012-01-16 09:47:24 +0400 |
| commit | 775bf2773858c50d2acfcdf71889984be94e7037 (patch) | |
| tree | bde361db470dacb057a2a30e4e43798ad4922cbf /drivers/scsi/hpsa.c | |
| parent | f2d7e40e8069f0d6b4958dbda4383f412f53c7d1 (diff) | |
| download | lwn-775bf2773858c50d2acfcdf71889984be94e7037.tar.gz lwn-775bf2773858c50d2acfcdf71889984be94e7037.zip | |
[SCSI] hpsa: do not sleep in atomic context in rmmod path.
Don't call kthread_stop with a spin lock held and interrupts
disabled because kthread_stop will sleep waiting for the thread
to stop.
Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
Diffstat (limited to 'drivers/scsi/hpsa.c')
| -rw-r--r-- | drivers/scsi/hpsa.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 5140f5d0fd6b..b96962c39449 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -4271,7 +4271,9 @@ static void stop_controller_lockup_detector(struct ctlr_info *h) remove_ctlr_from_lockup_detector_list(h); /* If the list of ctlr's to monitor is empty, stop the thread */ if (list_empty(&hpsa_ctlr_list)) { + spin_unlock_irqrestore(&lockup_detector_lock, flags); kthread_stop(hpsa_lockup_detector); + spin_lock_irqsave(&lockup_detector_lock, flags); hpsa_lockup_detector = NULL; } spin_unlock_irqrestore(&lockup_detector_lock, flags); |