diff options
| author | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2015-09-29 23:02:46 +0200 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2015-11-08 14:12:26 +0100 |
| commit | 5413eaba5ae093b0704b5458696922f6518adac4 (patch) | |
| tree | a511d09e9151691d5dc4634a82a5d4908d8866d1 /drivers/rtc | |
| parent | b1f9d790b59dc04f8813a49a92ddd8651770ffee (diff) | |
| download | lwn-5413eaba5ae093b0704b5458696922f6518adac4.tar.gz lwn-5413eaba5ae093b0704b5458696922f6518adac4.zip | |
rtc: pcf85063: return an error when date is invalid
Return an error when the date is invalid as the policy should be
implemented there.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Diffstat (limited to 'drivers/rtc')
| -rw-r--r-- | drivers/rtc/rtc-pcf85063.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/rtc/rtc-pcf85063.c b/drivers/rtc/rtc-pcf85063.c index b6d73dd881f2..63334cbeca41 100644 --- a/drivers/rtc/rtc-pcf85063.c +++ b/drivers/rtc/rtc-pcf85063.c @@ -80,13 +80,7 @@ static int pcf85063_get_datetime(struct i2c_client *client, struct rtc_time *tm) pcf85063->c_polarity = (buf[PCF85063_REG_MO] & PCF85063_MO_C) ? (tm->tm_year >= 100) : (tm->tm_year < 100); - /* the clock can give out invalid datetime, but we cannot return - * -EINVAL otherwise hwclock will refuse to set the time on bootup. - */ - if (rtc_valid_tm(tm) < 0) - dev_err(&client->dev, "retrieved date/time is not valid.\n"); - - return 0; + return rtc_valid_tm(tm); } static int pcf85063_set_datetime(struct i2c_client *client, struct rtc_time *tm) |