diff options
| author | Huacai Chen <chenhc@lemote.com> | 2020-06-20 20:04:43 +0800 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-07-16 11:15:43 +0200 |
| commit | 22f8d5a1bf230cf8567a4121fc3789babb46336d (patch) | |
| tree | 72cb58f4a9bf02254a9b6aeedc3ad4f301598fc9 /drivers/rtc/rtc-goldfish.c | |
| parent | d8f090dbeafdcc3d30761aa0062f19d1adf9ef08 (diff) | |
| download | lwn-22f8d5a1bf230cf8567a4121fc3789babb46336d.tar.gz lwn-22f8d5a1bf230cf8567a4121fc3789babb46336d.zip | |
rtc: goldfish: Enable interrupt in set_alarm() when necessary
When use goldfish rtc, the "hwclock" command fails with "select() to
/dev/rtc to wait for clock tick timed out". This is because "hwclock"
need the set_alarm() hook to enable interrupt when alrm->enabled is
true. This operation is missing in goldfish rtc (but other rtc drivers,
such as cmos rtc, enable interrupt here), so add it.
Signed-off-by: Huacai Chen <chenhc@lemote.com>
Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/1592654683-31314-1-git-send-email-chenhc@lemote.com
Diffstat (limited to 'drivers/rtc/rtc-goldfish.c')
| -rw-r--r-- | drivers/rtc/rtc-goldfish.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/rtc/rtc-goldfish.c b/drivers/rtc/rtc-goldfish.c index 27797157fcb3..6349d2cd3680 100644 --- a/drivers/rtc/rtc-goldfish.c +++ b/drivers/rtc/rtc-goldfish.c @@ -73,6 +73,7 @@ static int goldfish_rtc_set_alarm(struct device *dev, rtc_alarm64 = rtc_tm_to_time64(&alrm->time) * NSEC_PER_SEC; writel((rtc_alarm64 >> 32), base + TIMER_ALARM_HIGH); writel(rtc_alarm64, base + TIMER_ALARM_LOW); + writel(1, base + TIMER_IRQ_ENABLED); } else { /* * if this function was called with enabled=0 |