diff options
| author | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-12-06 00:14:48 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2020-12-16 00:33:33 +0100 |
| commit | f70cc33029fca3cf62bffb15102ea42eb4d097ac (patch) | |
| tree | 7c32ee1f3517ddad58b76c9b854f76fc9fb8a59b /drivers/rtc/class.c | |
| parent | ce9af89392024f57247187afc345991b784f9bae (diff) | |
| download | lwn-f70cc33029fca3cf62bffb15102ea42eb4d097ac.tar.gz lwn-f70cc33029fca3cf62bffb15102ea42eb4d097ac.zip | |
rtc: fix RTC removal
Since the rtc_register_device, removing an RTC device will end with a
refcount_t: underflow; use-after-free warning since put_device is called
twice in the device tear down path.
Fixes: fdcfd854333b ("rtc: rework rtc_register_device() resource management")
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Link: https://lore.kernel.org/r/20201205231449.610980-1-alexandre.belloni@bootlin.com
Diffstat (limited to 'drivers/rtc/class.c')
| -rw-r--r-- | drivers/rtc/class.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c index e6b44b7c4ad3..5c6748dfa55d 100644 --- a/drivers/rtc/class.c +++ b/drivers/rtc/class.c @@ -335,7 +335,6 @@ static void devm_rtc_unregister_device(void *data) cdev_device_del(&rtc->char_dev, &rtc->dev); rtc->ops = NULL; mutex_unlock(&rtc->ops_lock); - put_device(&rtc->dev); } static void devm_rtc_release_device(void *res) |