diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2019-03-25 10:49:33 +0100 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2019-05-09 17:09:54 +0200 |
| commit | e926b12c611c2095c7976e2ed31753ad6eb5ff1a (patch) | |
| tree | c0c74a6953c3949d1d5007cb4e2eb3c6dca287dd /drivers/pwm | |
| parent | 738a1cfec2edb4a6c53ac34fcb29447227dd135e (diff) | |
| download | lwn-e926b12c611c2095c7976e2ed31753ad6eb5ff1a.tar.gz lwn-e926b12c611c2095c7976e2ed31753ad6eb5ff1a.zip | |
pwm: Clear chip_data in pwm_put()
After a PWM is disposed by its user the per chip data becomes invalid.
Clear the data in common code instead of the device drivers to get
consistent behaviour. Before this patch only three of nine drivers
cleaned up here.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/core.c | 1 | ||||
| -rw-r--r-- | drivers/pwm/pwm-berlin.c | 1 | ||||
| -rw-r--r-- | drivers/pwm/pwm-pca9685.c | 1 | ||||
| -rw-r--r-- | drivers/pwm/pwm-samsung.c | 1 |
4 files changed, 1 insertions, 3 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 8c9200a0df5e..3998ebd51db4 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -877,6 +877,7 @@ void pwm_put(struct pwm_device *pwm) if (pwm->chip->ops->free) pwm->chip->ops->free(pwm->chip, pwm); + pwm_set_chip_data(pwm, NULL); pwm->label = NULL; module_put(pwm->chip->ops->owner); diff --git a/drivers/pwm/pwm-berlin.c b/drivers/pwm/pwm-berlin.c index 7c8d6a168ceb..b91c477cc84b 100644 --- a/drivers/pwm/pwm-berlin.c +++ b/drivers/pwm/pwm-berlin.c @@ -84,7 +84,6 @@ static void berlin_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm) { struct berlin_pwm_channel *channel = pwm_get_chip_data(pwm); - pwm_set_chip_data(pwm, NULL); kfree(channel); } diff --git a/drivers/pwm/pwm-pca9685.c b/drivers/pwm/pwm-pca9685.c index a7eaf962a95b..567f5e2771c4 100644 --- a/drivers/pwm/pwm-pca9685.c +++ b/drivers/pwm/pwm-pca9685.c @@ -176,7 +176,6 @@ static void pca9685_pwm_gpio_free(struct gpio_chip *gpio, unsigned int offset) pm_runtime_put(pca->chip.dev); mutex_lock(&pca->lock); pwm = &pca->chip.pwms[offset]; - pwm_set_chip_data(pwm, NULL); mutex_unlock(&pca->lock); } diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c index 062f2cfc45ec..3762432dd6a7 100644 --- a/drivers/pwm/pwm-samsung.c +++ b/drivers/pwm/pwm-samsung.c @@ -238,7 +238,6 @@ static int pwm_samsung_request(struct pwm_chip *chip, struct pwm_device *pwm) static void pwm_samsung_free(struct pwm_chip *chip, struct pwm_device *pwm) { devm_kfree(chip->dev, pwm_get_chip_data(pwm)); - pwm_set_chip_data(pwm, NULL); } static int pwm_samsung_enable(struct pwm_chip *chip, struct pwm_device *pwm) |