diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-11-23 10:56:20 +0100 |
|---|---|---|
| committer | Thierry Reding <thierry.reding@gmail.com> | 2023-12-20 16:04:13 +0100 |
| commit | b0445a18d3eef36b7dc4e07a0ccb4f7178251942 (patch) | |
| tree | 71b2e2cf8eb0a127848dff0e27e4a9886bfcba34 /drivers/pwm | |
| parent | 1c9a2ad84f5a7450265a2ffcdb27715dbca2b980 (diff) | |
| download | lwn-b0445a18d3eef36b7dc4e07a0ccb4f7178251942.tar.gz lwn-b0445a18d3eef36b7dc4e07a0ccb4f7178251942.zip | |
pwm: Narrow scope of struct pwm_device pointer
In the expression determining the size of the allocation for chip->pwms
it's more natural to use sizeof(*chip->pwms) than sizeof(*pwm). With
that changed, the variable pwm is only used in a for loop and its scope
can be reduced accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <thierry.reding@gmail.com>
Diffstat (limited to 'drivers/pwm')
| -rw-r--r-- | drivers/pwm/core.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index fb36b3d559a7..b0e50ca9398a 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -208,7 +208,6 @@ static bool pwm_ops_check(const struct pwm_chip *chip) */ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) { - struct pwm_device *pwm; unsigned int i; int ret; @@ -220,7 +219,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) chip->owner = owner; - chip->pwms = kcalloc(chip->npwm, sizeof(*pwm), GFP_KERNEL); + chip->pwms = kcalloc(chip->npwm, sizeof(*chip->pwms), GFP_KERNEL); if (!chip->pwms) return -ENOMEM; @@ -236,7 +235,7 @@ int __pwmchip_add(struct pwm_chip *chip, struct module *owner) chip->id = ret; for (i = 0; i < chip->npwm; i++) { - pwm = &chip->pwms[i]; + struct pwm_device *pwm = &chip->pwms[i]; pwm->chip = chip; pwm->hwpwm = i; |