diff options
| author | Lukasz Luba <lukasz.luba@arm.com> | 2020-11-17 13:47:59 +0000 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2020-11-23 18:27:58 +0100 |
| commit | b4ba76fb1c999384c1b0840d216d42abcd611024 (patch) | |
| tree | 70ea8ad7e4b8df995150a54862f1496b6a8a662e /drivers/powercap | |
| parent | 8a9d881f22d7a0e06a46a326d0880fb45a06d3b5 (diff) | |
| download | lwn-b4ba76fb1c999384c1b0840d216d42abcd611024.tar.gz lwn-b4ba76fb1c999384c1b0840d216d42abcd611024.zip | |
powercap: Adjust printing the constraint name with new line
The constrain name has limit of size 30, which sometimes might be hit.
When this happens the new line might get lost. Prevent this and set the
max limit for name string length equal 29. This would result is proper
string clamping (when needed) and storing '\n' at index 29 and '\0' at 30,
so similarly as desired originally.
Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Diffstat (limited to 'drivers/powercap')
| -rw-r--r-- | drivers/powercap/powercap_sys.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/powercap/powercap_sys.c b/drivers/powercap/powercap_sys.c index f808c5fa9838..602c55287e7d 100644 --- a/drivers/powercap/powercap_sys.c +++ b/drivers/powercap/powercap_sys.c @@ -170,9 +170,8 @@ static ssize_t show_constraint_name(struct device *dev, if (pconst && pconst->ops && pconst->ops->get_name) { name = pconst->ops->get_name(power_zone, id); if (name) { - snprintf(buf, POWERCAP_CONSTRAINT_NAME_LEN, - "%s\n", name); - buf[POWERCAP_CONSTRAINT_NAME_LEN] = '\0'; + sprintf(buf, "%.*s\n", POWERCAP_CONSTRAINT_NAME_LEN - 1, + name); len = strlen(buf); } } |