diff options
| author | Felix Gu <ustc.gu@gmail.com> | 2026-03-02 22:31:44 +0800 |
|---|---|---|
| committer | Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> | 2026-03-04 09:16:41 +0100 |
| commit | 5c3daa5301693d2e5364483a3405649a0fdaed98 (patch) | |
| tree | cac5b0499468fb2b7c5c0688b19fb5bb484c7b91 /drivers/power | |
| parent | 11439c4635edd669ae435eec308f4ab8a0804808 (diff) | |
| download | lwn-5c3daa5301693d2e5364483a3405649a0fdaed98.tar.gz lwn-5c3daa5301693d2e5364483a3405649a0fdaed98.zip | |
power: sequencing: pcie-m2: Fix device node reference leak in probe
In pwrseq_pcie_m2_probe(), ctx->of_node acquires an explicit reference
to the device node using of_node_get(), but there is no corresponding
of_node_put() in the driver's error handling paths or removal.
Since the ctx is tied to the lifecycle of the platform device, there
is no need to hold an additional reference to the device's own of_node.
Fixes: 52e7b5bd62ba ("power: sequencing: Add the Power Sequencing driver for the PCIe M.2 connectors")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260302-m2-v1-1-a6533e18aa69@gmail.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Diffstat (limited to 'drivers/power')
| -rw-r--r-- | drivers/power/sequencing/pwrseq-pcie-m2.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/sequencing/pwrseq-pcie-m2.c b/drivers/power/sequencing/pwrseq-pcie-m2.c index d31a7dd8b35c..dadb4aad9d5d 100644 --- a/drivers/power/sequencing/pwrseq-pcie-m2.c +++ b/drivers/power/sequencing/pwrseq-pcie-m2.c @@ -109,7 +109,7 @@ static int pwrseq_pcie_m2_probe(struct platform_device *pdev) if (!ctx) return -ENOMEM; - ctx->of_node = of_node_get(dev->of_node); + ctx->of_node = dev_of_node(dev); ctx->pdata = device_get_match_data(dev); if (!ctx->pdata) return dev_err_probe(dev, -ENODEV, |