diff options
| author | Andrew F. Davis <afd@ti.com> | 2015-09-22 14:35:07 -0500 |
|---|---|---|
| committer | Sebastian Reichel <sre@kernel.org> | 2015-09-23 16:23:12 +0200 |
| commit | 424cfde49acaf1426e90837961e8aead0238b11b (patch) | |
| tree | 4916468deee9df2e8873ffd05e175bdd27349b54 /drivers/power/bq27xxx_battery.c | |
| parent | 081bab217db769526c1202c87099ff69737126ae (diff) | |
| download | lwn-424cfde49acaf1426e90837961e8aead0238b11b.tar.gz lwn-424cfde49acaf1426e90837961e8aead0238b11b.zip | |
power: bq27xxx_battery: Platform initialization must declare a device
When initialized as a platform device the initializer must now specify
a device. An empty device name is no longer valid.
Signed-off-by: Andrew F. Davis <afd@ti.com>
Signed-off-by: Sebastian Reichel <sre@kernel.org>
Diffstat (limited to 'drivers/power/bq27xxx_battery.c')
| -rw-r--r-- | drivers/power/bq27xxx_battery.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/drivers/power/bq27xxx_battery.c b/drivers/power/bq27xxx_battery.c index e72055ce7b3c..073441383df1 100644 --- a/drivers/power/bq27xxx_battery.c +++ b/drivers/power/bq27xxx_battery.c @@ -91,8 +91,6 @@ struct bq27xxx_access_methods { int (*read)(struct bq27xxx_device_info *di, u8 reg, bool single); }; -enum bq27xxx_chip { BQ27000, BQ27500, BQ27425, BQ27742, BQ27510}; - struct bq27xxx_reg_cache { int temperature; int time_to_empty; @@ -1036,6 +1034,11 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev) return -EINVAL; } + if (!pdata->chip) { + dev_err(&pdev->dev, "no device supplied\n"); + return -EINVAL; + } + di = devm_kzalloc(&pdev->dev, sizeof(*di), GFP_KERNEL); if (!di) return -ENOMEM; @@ -1043,7 +1046,7 @@ static int bq27xxx_battery_platform_probe(struct platform_device *pdev) platform_set_drvdata(pdev, di); di->dev = &pdev->dev; - di->chip = BQ27000; + di->chip = pdata->chip; name = pdata->name ?: dev_name(&pdev->dev); di->bus.read = &bq27xxx_battery_platform_read; |