diff options
| author | Bjorn Helgaas <bjorn.helgaas@hp.com> | 2007-08-15 10:32:13 -0600 |
|---|---|---|
| committer | Len Brown <len.brown@intel.com> | 2007-08-24 01:27:24 -0400 |
| commit | b173491339b9ae7f1322241ce6228c1268513a39 (patch) | |
| tree | dca8b3a7021d7957d60023e34ac96a9df5215421 /drivers/pnp/isapnp | |
| parent | 4f0217e30249ac0eb13b65ef64f2aee627465da2 (diff) | |
| download | lwn-b173491339b9ae7f1322241ce6228c1268513a39.tar.gz lwn-b173491339b9ae7f1322241ce6228c1268513a39.zip | |
PNP: remove null pointer checks
Remove some null pointer checks. Null pointers in these areas indicate
programming errors, and I think it's better to oops immediately rather
than return an error that is easily ignored.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Acked-by: Adam Belay <abelay@novell.com>
Signed-off-by: Len Brown <len.brown@intel.com>
Diffstat (limited to 'drivers/pnp/isapnp')
| -rw-r--r-- | drivers/pnp/isapnp/core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pnp/isapnp/core.c b/drivers/pnp/isapnp/core.c index 1a0d33a12862..b035d60a1dcc 100644 --- a/drivers/pnp/isapnp/core.c +++ b/drivers/pnp/isapnp/core.c @@ -1040,7 +1040,7 @@ static int isapnp_set_resources(struct pnp_dev *dev, static int isapnp_disable_resources(struct pnp_dev *dev) { - if (!dev || !dev->active) + if (!dev->active) return -EINVAL; isapnp_cfg_begin(dev->card->number, dev->number); isapnp_deactivate(dev->number); |