diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2014-11-24 20:30:29 +0100 |
|---|---|---|
| committer | Darren Hart <dvhart@linux.intel.com> | 2014-12-03 10:10:14 -0800 |
| commit | 0098181016dd45c1c417656ba36b87d9101cbb83 (patch) | |
| tree | adb5cead8a3f2307e94918ac9369c95e7b2166c9 /drivers/platform/x86/fujitsu-laptop.c | |
| parent | a39f46df33c6847399f9b41b74ef09a4095fb996 (diff) | |
| download | lwn-0098181016dd45c1c417656ba36b87d9101cbb83.tar.gz lwn-0098181016dd45c1c417656ba36b87d9101cbb83.zip | |
platform: x86: Deletion of checks before backlight_device_unregister()
The backlight_device_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
For msi-wmi.c:
Acked-by: Anisse Astier <anisse@astier.eu>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Diffstat (limited to 'drivers/platform/x86/fujitsu-laptop.c')
| -rw-r--r-- | drivers/platform/x86/fujitsu-laptop.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 2655d4a988f3..460715dcf7db 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -1154,8 +1154,7 @@ fail_hotkey1: fail_hotkey: platform_driver_unregister(&fujitsupf_driver); fail_backlight: - if (fujitsu->bl_device) - backlight_device_unregister(fujitsu->bl_device); + backlight_device_unregister(fujitsu->bl_device); fail_sysfs_group: sysfs_remove_group(&fujitsu->pf_device->dev.kobj, &fujitsupf_attribute_group); @@ -1179,8 +1178,7 @@ static void __exit fujitsu_cleanup(void) platform_driver_unregister(&fujitsupf_driver); - if (fujitsu->bl_device) - backlight_device_unregister(fujitsu->bl_device); + backlight_device_unregister(fujitsu->bl_device); sysfs_remove_group(&fujitsu->pf_device->dev.kobj, &fujitsupf_attribute_group); |