diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2016-09-19 10:17:32 +0200 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-09-19 11:01:33 +0200 |
| commit | 31ebe86d6ef5f3280705e7ac9ab366f60f4e699c (patch) | |
| tree | 0de92bdb2b10ba07ada81c47faf4deefcd5fb852 /drivers/pinctrl | |
| parent | 07bc299b11617d54a948797270bbfe09ecc2f87a (diff) | |
| download | lwn-31ebe86d6ef5f3280705e7ac9ab366f60f4e699c.tar.gz lwn-31ebe86d6ef5f3280705e7ac9ab366f60f4e699c.zip | |
pinctrl: nomadik: don't default-flag IRQs as falling
There is no point in adding any default trigger for these
GPIO interrupts: the device tree should contain all trigger
information and the platforms using the driver boots
exclusively from device tree.
Also the boot log is nagging me to fix this:
[ 0.771057] ------------[ cut here ]------------
[ 0.775695] WARNING: CPU: 0 PID: 1 at
../drivers/gpio/gpiolib.c:1622 _gpiochip_irqchip_add+0x138/0x160
[ 0.785034] /soc/gpio@8012e000: Ignoring 2 default trigger
(...)
[ 0.942962] gpio 8012e000.gpio: at address e08f8000
(etc ad nauseam)
Suggested-by: Marc Zyngier <marc.zyngier@arm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl')
| -rw-r--r-- | drivers/pinctrl/nomadik/pinctrl-nomadik.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c index 205fb399268a..d318ca055489 100644 --- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c +++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c @@ -1177,7 +1177,7 @@ static int nmk_gpio_probe(struct platform_device *dev) irqchip, 0, handle_edge_irq, - IRQ_TYPE_EDGE_FALLING); + IRQ_TYPE_NONE); if (ret) { dev_err(&dev->dev, "could not add irqchip\n"); gpiochip_remove(&nmk_chip->chip); |