diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2016-02-06 22:56:36 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-02-15 19:42:41 +0100 |
| commit | 424a6c607c169ca0ac8431424f28fc839b45b14c (patch) | |
| tree | 292a3a6dcc74f9bf62f81dc5d3afa7fe4a18a649 /drivers/pinctrl/pinctrl-amd.c | |
| parent | 41bd0c52c0d3e38202608cfe133faca9a0e53ae8 (diff) | |
| download | lwn-424a6c607c169ca0ac8431424f28fc839b45b14c.tar.gz lwn-424a6c607c169ca0ac8431424f28fc839b45b14c.zip | |
pinctrl: Fix return value check in amd_gpio_probe()
In case of error, the function devm_ioremap_nocache() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-amd.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-amd.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 657449431301..5c025f5b5048 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -753,8 +753,8 @@ static int amd_gpio_probe(struct platform_device *pdev) gpio_dev->base = devm_ioremap_nocache(&pdev->dev, res->start, resource_size(res)); - if (IS_ERR(gpio_dev->base)) - return PTR_ERR(gpio_dev->base); + if (!gpio_dev->base) + return -ENOMEM; irq_base = platform_get_irq(pdev, 0); if (irq_base < 0) { |