diff options
| author | Zhiyong Tao <zhiyong.tao@mediatek.com> | 2021-03-21 11:31:50 +0800 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2021-03-25 10:14:50 +0100 |
| commit | 42a46434e9b18b35d2e57433cdbeff3233ca9765 (patch) | |
| tree | 2ae95aa6a5a8d58de13a40b233e859c853d861c3 /drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | |
| parent | 1517dad8e7129c5e28bd7b536c560f0f0bff87a4 (diff) | |
| download | lwn-42a46434e9b18b35d2e57433cdbeff3233ca9765.tar.gz lwn-42a46434e9b18b35d2e57433cdbeff3233ca9765.zip | |
pinctrl: add lock in mtk_rmw function.
When multiple threads operate on the same register resource
which include multiple pin, It will make the register resource
wrong to control. So we add lock to avoid the case.
Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
Link: https://lore.kernel.org/r/20210321033150.15380-2-zhiyong.tao@mediatek.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c')
| -rw-r--r-- | drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index 72f17f26acd8..fcf7c3eeee4a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -58,10 +58,14 @@ void mtk_rmw(struct mtk_pinctrl *pctl, u8 i, u32 reg, u32 mask, u32 set) { u32 val; + mutex_lock(&pctl->lock); + val = mtk_r32(pctl, i, reg); val &= ~mask; val |= set; mtk_w32(pctl, i, reg, val); + + mutex_unlock(&pctl->lock); } static int mtk_hw_pin_field_lookup(struct mtk_pinctrl *hw, |