diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-05-25 18:50:32 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2021-05-31 14:11:44 +0530 |
| commit | b8203ec7f58ae925e10fadd3d136073ae7503a6e (patch) | |
| tree | cd7d1801be81d964e35a2bf94cb4c40059e253e3 /drivers/phy/ti/phy-j721e-wiz.c | |
| parent | aaac9a1bd370338ce372669eb9a6059d16b929aa (diff) | |
| download | lwn-b8203ec7f58ae925e10fadd3d136073ae7503a6e.tar.gz lwn-b8203ec7f58ae925e10fadd3d136073ae7503a6e.zip | |
phy: ti: Fix an error code in wiz_probe()
When the code execute this if statement, the value of ret is 0.
However, we can see from the dev_err() log that the value of
ret should be -EINVAL.
Clean up smatch warning:
drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code 'ret'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Fixes: c9f9eba06629 ("phy: ti: j721e-wiz: Manage typec-gpio-dir")
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/ti/phy-j721e-wiz.c')
| -rw-r--r-- | drivers/phy/ti/phy-j721e-wiz.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 9eb6d37c907e..126f5b8735cc 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev) if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN || wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) { + ret = -EINVAL; dev_err(dev, "Invalid typec-dir-debounce property\n"); goto err_addr_to_resource; } |