diff options
| author | EJ Hsu <ejh@nvidia.com> | 2023-06-09 14:29:32 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-06-21 17:31:41 +0530 |
| commit | c0c2fcb1325d0d4f3b322b5ee49385f8eca2560d (patch) | |
| tree | f8c6296245390fcf44b865d5021e612aa79ea86a /drivers/phy/tegra | |
| parent | 1abd3127bde7b67d3e57c02a10b8d77a67decc84 (diff) | |
| download | lwn-c0c2fcb1325d0d4f3b322b5ee49385f8eca2560d.tar.gz lwn-c0c2fcb1325d0d4f3b322b5ee49385f8eca2560d.zip | |
phy: tegra: xusb: Clear the driver reference in usb-phy dev
For the dual-role port, it will assign the phy dev to usb-phy dev and
use the port dev driver as the dev driver of usb-phy.
When we try to destroy the port dev, it will destroy its dev driver
as well. But we did not remove the reference from usb-phy dev. This
might cause the use-after-free issue in KASAN.
Fixes: e8f7d2f409a1 ("phy: tegra: xusb: Add usb-phy support")
Cc: stable@vger.kernel.org
Signed-off-by: EJ Hsu <ejh@nvidia.com>
Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Link: https://lore.kernel.org/r/20230609062932.3276509-1-haotienh@nvidia.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/tegra')
| -rw-r--r-- | drivers/phy/tegra/xusb.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index b55d4e9f42b5..b5bad46a04a3 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -568,6 +568,7 @@ static void tegra_xusb_port_unregister(struct tegra_xusb_port *port) usb_role_switch_unregister(port->usb_role_sw); cancel_work_sync(&port->usb_phy_work); usb_remove_phy(&port->usb_phy); + port->usb_phy.dev->driver = NULL; } if (port->ops->remove) |