diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-16 16:54:03 +0200 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-08-30 12:59:58 +0530 |
| commit | 533e13305c16c63915f7cc8a36ed7ef717e15378 (patch) | |
| tree | d6a5f22987a53f60b53fd0e2c3ec524172edca94 /drivers/phy/tegra | |
| parent | c77c1853a2ecf818cd6842b9d5907ed71d1e2c29 (diff) | |
| download | lwn-533e13305c16c63915f7cc8a36ed7ef717e15378.tar.gz lwn-533e13305c16c63915f7cc8a36ed7ef717e15378.zip | |
phy: tegra: xusb: Only warn once about reset problems in .remove()
The single difference between returning 0 and returning an error code in
a platform remove callback is that in the latter case the platform core
emits a warning about the error being ignored.
If reset_control_assert() fails there is already a warning, so suppress
the more generic (and less helpful) by returning 0 in
tegra_xusb_padctl_remove().
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220716145403.107703-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/tegra')
| -rw-r--r-- | drivers/phy/tegra/xusb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index aa5237eacd29..d04a80c436c3 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -1270,7 +1270,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) padctl->soc->ops->remove(padctl); - return err; + return 0; } static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev) |