diff options
| author | Shang XiaoJing <shangxiaojing@huawei.com> | 2022-12-05 19:58:23 +0800 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2023-01-13 23:10:52 +0530 |
| commit | 5daba914da0e48950e9407ea4d75fa57029c9adc (patch) | |
| tree | 723e1472bd8aa10b6af84802ef1b4c08bfe8eb43 /drivers/phy/rockchip | |
| parent | ec4a1d9301100c011312357ea25627b98eb293d5 (diff) | |
| download | lwn-5daba914da0e48950e9407ea4d75fa57029c9adc.tar.gz lwn-5daba914da0e48950e9407ea4d75fa57029c9adc.zip | |
phy: rockchip-inno-usb2: Fix missing clk_disable_unprepare() in rockchip_usb2phy_power_on()
The clk_disable_unprepare() should be called in the error handling of
rockchip_usb2phy_power_on().
Fixes: 0e08d2a727e6 ("phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Link: https://lore.kernel.org/r/20221205115823.16957-1-shangxiaojing@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/phy/rockchip')
| -rw-r--r-- | drivers/phy/rockchip/phy-rockchip-inno-usb2.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c index e6ededc51523..a0bc10aa7961 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-usb2.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-usb2.c @@ -485,8 +485,10 @@ static int rockchip_usb2phy_power_on(struct phy *phy) return ret; ret = property_enable(base, &rport->port_cfg->phy_sus, false); - if (ret) + if (ret) { + clk_disable_unprepare(rphy->clk480m); return ret; + } /* waiting for the utmi_clk to become stable */ usleep_range(1500, 2000); |