summaryrefslogtreecommitdiff
path: root/drivers/perf
diff options
context:
space:
mode:
authorCatalin Marinas <catalin.marinas@arm.com>2016-07-08 12:13:20 +0100
committerCatalin Marinas <catalin.marinas@arm.com>2016-07-08 14:29:18 +0100
commit90f777beb788d08300f4a1482cb4fd37a401b472 (patch)
tree1dde16fbc3122b9ab29a60fae912b29460cd5ae1 /drivers/perf
parent40f87d3114b8a1e730ac8f3dc3cf1efe33124776 (diff)
downloadlwn-90f777beb788d08300f4a1482cb4fd37a401b472.tar.gz
lwn-90f777beb788d08300f4a1482cb4fd37a401b472.zip
arm64: Fix vdso-offsets.h dependency
arch/arm64/kernel/{vdso,signal}.c include generated/vdso-offsets.h, and therefore the symbol offsets must be generated before these files are compiled. The current rules in arm64/kernel/Makefile do not actually enforce this, because even though $(obj)/vdso is listed as a prerequisite for vdso-offsets.h, this does not result in the intended effect of building the vdso subdirectory (before all the other objects). As a consequence, depending on the order in which the rules are followed, vdso-offsets.h is updated or not before arm64/kernel/{vdso,signal}.o are built. The current rules also impose an unnecessary dependency on vdso-offsets.h for all arm64/kernel/*.o, resulting in unnecessary rebuilds. This patch removes the arch/arm64/kernel/vdso/vdso-offsets.h file generation, leaving only the include/generated/vdso-offsets.h one. It adds a forced dependency check of the vdso-offsets.h file in arch/arm64/kernel/Makefile which, if not up to date according to the arch/arm64/kernel/vdso/Makefile rules (depending on vdso.so.dbg), will trigger the vdso/ subdirectory build and vdso-offsets.h re-generation. Automatic kbuild dependency rules between kernel/{vdso,signal}.c rules and vdso-offsets.h will guarantee that the vDSO object is built first, followed by the generated symbol offsets header file. Reported-by: Kevin Brodsky <kevin.brodsky@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Diffstat (limited to 'drivers/perf')
0 files changed, 0 insertions, 0 deletions