diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-02-25 16:23:22 +0300 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-04-22 23:28:34 -0400 |
| commit | 5a3edbcd6205ed320df53bae338761cf5ba98b94 (patch) | |
| tree | d53621007ada482f33f696bf8a64af86866ae970 /drivers/pci/hotplug | |
| parent | 02e0fab6a0bc9c941a896b608368cc009efc9ccc (diff) | |
| download | lwn-5a3edbcd6205ed320df53bae338761cf5ba98b94.tar.gz lwn-5a3edbcd6205ed320df53bae338761cf5ba98b94.zip | |
PCI: cpcihp: Add missing curly braces in cpci_configure_slot()
[ Upstream commit bc3b5b47c80da8838758731d423179262c9c36ec ]
I don't have this hardware but it looks like we weren't adding bridge
devices as intended. Maybe the bridge is always the last device?
Fixes: 05b125004815 ("PCI: cpcihp: Iterate over all devices in slot, not functions 0-7")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Yijing Wang <wangyijing@huawei.com>
CC: stable@vger.kernel.org # v3.9+
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'drivers/pci/hotplug')
| -rw-r--r-- | drivers/pci/hotplug/cpci_hotplug_pci.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/pci/hotplug/cpci_hotplug_pci.c b/drivers/pci/hotplug/cpci_hotplug_pci.c index 7d48ecae6695..788db48dbbad 100644 --- a/drivers/pci/hotplug/cpci_hotplug_pci.c +++ b/drivers/pci/hotplug/cpci_hotplug_pci.c @@ -286,11 +286,12 @@ int cpci_configure_slot(struct slot *slot) } parent = slot->dev->bus; - list_for_each_entry(dev, &parent->devices, bus_list) + list_for_each_entry(dev, &parent->devices, bus_list) { if (PCI_SLOT(dev->devfn) != PCI_SLOT(slot->devfn)) continue; if (pci_is_bridge(dev)) pci_hp_add_bridge(dev); + } pci_assign_unassigned_bridge_resources(parent->self); |