summaryrefslogtreecommitdiff
path: root/drivers/parport
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2021-07-30 11:07:10 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-08-27 16:18:42 +0200
commit0be883a0d795d9146f5325de582584147dd0dcdc (patch)
treeb1f65c448d280c267c1a0cfb68e29fac41688d99 /drivers/parport
parent8c61951b372d83b426a66dafc9c4ac24b3ce3335 (diff)
downloadlwn-0be883a0d795d9146f5325de582584147dd0dcdc.tar.gz
lwn-0be883a0d795d9146f5325de582584147dd0dcdc.zip
parport: remove non-zero check on count
The check for count appears to be incorrect since a non-zero count check occurs a couple of statements earlier. Currently the check is always false and the dev->port->irq != PARPORT_IRQ_NONE part of the check is never tested and the if statement is dead-code. Fix this by removing the check on count. Note that this code is pre-git history, so I can't find a sha for it. Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> Signed-off-by: Colin Ian King <colin.king@canonical.com> Addresses-Coverity: ("Logically dead code") Link: https://lore.kernel.org/r/20210730100710.27405-1-colin.king@canonical.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
-rw-r--r--drivers/parport/ieee1284_ops.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/parport/ieee1284_ops.c b/drivers/parport/ieee1284_ops.c
index 2c11bd3fe1fd..17061f1df0f4 100644
--- a/drivers/parport/ieee1284_ops.c
+++ b/drivers/parport/ieee1284_ops.c
@@ -518,7 +518,7 @@ size_t parport_ieee1284_ecp_read_data (struct parport *port,
goto out;
/* Yield the port for a while. */
- if (count && dev->port->irq != PARPORT_IRQ_NONE) {
+ if (dev->port->irq != PARPORT_IRQ_NONE) {
parport_release (dev);
schedule_timeout_interruptible(msecs_to_jiffies(40));
parport_claim_or_block (dev);