diff options
| author | Sudip Mukherjee <sudipm.mukherjee@gmail.com> | 2015-06-15 20:05:51 +0530 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-07-22 21:15:49 -0700 |
| commit | 68d35c7b3b1aa686e3039eb2626bf5e3ea8dbe81 (patch) | |
| tree | 1b4e728abf7ba46894bc6c2ce8a2659271838ff6 /drivers/parport | |
| parent | 23c405912b881e3ca516554efde852c2ad550b31 (diff) | |
| download | lwn-68d35c7b3b1aa686e3039eb2626bf5e3ea8dbe81.tar.gz lwn-68d35c7b3b1aa686e3039eb2626bf5e3ea8dbe81.zip | |
parport: fix freeing freed memory
After the reference count becomes 0 when put_device() is called, it will
execute the release callback where we are freeing all the allocated
memory associated with the device. So if we just continue on the error
path then we are again freeing devname and trying to dereference par_dev
which has already been free-ed in the release callback.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/parport')
| -rw-r--r-- | drivers/parport/share.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/parport/share.c b/drivers/parport/share.c index 1efec44e03aa..c02b5f27798b 100644 --- a/drivers/parport/share.c +++ b/drivers/parport/share.c @@ -892,8 +892,10 @@ parport_register_dev_model(struct parport *port, const char *name, par_dev->dev.release = free_pardevice; par_dev->devmodel = true; ret = device_register(&par_dev->dev); - if (ret) - goto err_put_dev; + if (ret) { + put_device(&par_dev->dev); + goto err_put_port; + } /* Chain this onto the list */ par_dev->prev = NULL; @@ -940,8 +942,6 @@ parport_register_dev_model(struct parport *port, const char *name, return par_dev; -err_put_dev: - put_device(&par_dev->dev); err_free_devname: kfree(devname); err_free_par_dev: |