diff options
| author | Robert Richter <robert.richter@amd.com> | 2008-12-18 22:09:13 +0100 |
|---|---|---|
| committer | Robert Richter <robert.richter@amd.com> | 2008-12-29 18:54:44 +0100 |
| commit | 6352d92dec0c4b833c12a169e86762c05d0396f3 (patch) | |
| tree | 1dc1257cce235c356394741acd426bf527e1b9ff /drivers/oprofile | |
| parent | 317f33bce6d43367a2fd170bc87ba18a88d2621d (diff) | |
| download | lwn-6352d92dec0c4b833c12a169e86762c05d0396f3.tar.gz lwn-6352d92dec0c4b833c12a169e86762c05d0396f3.zip | |
oprofile: simplify oprofile_begin_trace()
This patch removes the unused return parameter in
oprofile_begin_trace(). Also, oprofile_begin_trace() and
oprofile_end_trace() are inline now.
Signed-off-by: Robert Richter <robert.richter@amd.com>
Diffstat (limited to 'drivers/oprofile')
| -rw-r--r-- | drivers/oprofile/cpu_buffer.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/drivers/oprofile/cpu_buffer.c b/drivers/oprofile/cpu_buffer.c index 9e66c384e016..435bd6e08d5b 100644 --- a/drivers/oprofile/cpu_buffer.c +++ b/drivers/oprofile/cpu_buffer.c @@ -265,14 +265,13 @@ fail: return 0; } -static int oprofile_begin_trace(struct oprofile_cpu_buffer *cpu_buf) +static inline void oprofile_begin_trace(struct oprofile_cpu_buffer *cpu_buf) { add_code(cpu_buf, CPU_TRACE_BEGIN); cpu_buf->tracing = 1; - return 1; } -static void oprofile_end_trace(struct oprofile_cpu_buffer *cpu_buf) +static inline void oprofile_end_trace(struct oprofile_cpu_buffer *cpu_buf) { cpu_buf->tracing = 0; } @@ -288,8 +287,7 @@ __oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, return; } - if (!oprofile_begin_trace(cpu_buf)) - return; + oprofile_begin_trace(cpu_buf); /* * if log_sample() fail we can't backtrace since we lost the @@ -297,6 +295,7 @@ __oprofile_add_ext_sample(unsigned long pc, struct pt_regs * const regs, */ if (log_sample(cpu_buf, pc, is_kernel, event)) oprofile_ops.backtrace(regs, oprofile_backtrace_depth); + oprofile_end_trace(cpu_buf); } |