diff options
| author | Andrew Halaney <ahalaney@redhat.com> | 2023-06-26 08:46:46 -0500 |
|---|---|---|
| committer | Viresh Kumar <viresh.kumar@linaro.org> | 2023-06-27 07:35:14 +0530 |
| commit | 5fb2864cbd50a84a73af4fdd900b31f2daddea34 (patch) | |
| tree | c2622c367233dc1783c3c57ee0c581f7bffaeeed /drivers/opp | |
| parent | fa155f4f834882a79788218aea4914568b41dd0f (diff) | |
| download | lwn-5fb2864cbd50a84a73af4fdd900b31f2daddea34.tar.gz lwn-5fb2864cbd50a84a73af4fdd900b31f2daddea34.zip | |
OPP: Properly propagate error along when failing to get icc_path
fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
failed to actually use the error it was trying to log:
smatch warnings:
drivers/opp/of.c:516 dev_pm_opp_of_find_icc_paths() warn: passing zero to 'dev_err_probe'
Make sure to use the right error and pass it along.
Fixes: fa155f4f8348 ("OPP: Use dev_err_probe() when failing to get icc_path")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202306262008.guNLgjt6-lkp@intel.com/
Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Diffstat (limited to 'drivers/opp')
| -rw-r--r-- | drivers/opp/of.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index 1f0923cc1cd9..ada4963c7cfa 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -513,7 +513,7 @@ int dev_pm_opp_of_find_icc_paths(struct device *dev, for (i = 0; i < num_paths; i++) { paths[i] = of_icc_get_by_index(dev, i); if (IS_ERR(paths[i])) { - ret = dev_err_probe(dev, ret, "%s: Unable to get path%d\n", __func__, i); + ret = dev_err_probe(dev, PTR_ERR(paths[i]), "%s: Unable to get path%d\n", __func__, i); goto err; } } |