summaryrefslogtreecommitdiff
path: root/drivers/of
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2014-12-02 13:54:00 +0100
committerGrant Likely <grant.likely@linaro.org>2014-12-03 23:12:41 +0000
commitc46ca3c8310b61d253a39ff1375ea97912794cd1 (patch)
treec2083c006491b8ad03eed666ff1ce60dd7b62e15 /drivers/of
parent70161ff336674ecfd20614a9c0c61cb17a6e9e83 (diff)
downloadlwn-c46ca3c8310b61d253a39ff1375ea97912794cd1.tar.gz
lwn-c46ca3c8310b61d253a39ff1375ea97912794cd1.zip
of: Delete unnecessary check before calling "of_node_put()"
The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Grant Likely <grant.likely@linaro.org>
Diffstat (limited to 'drivers/of')
-rw-r--r--drivers/of/unittest.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 1807a0458648..844838e11ef1 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -516,8 +516,7 @@ static void __init of_selftest_changeset(void)
/* Make sure node names are constructed correctly */
selftest((np = of_find_node_by_path("/testcase-data/changeset/n2/n21")),
"'%s' not added\n", n21->full_name);
- if (np)
- of_node_put(np);
+ of_node_put(np);
mutex_lock(&of_mutex);
selftest(!of_changeset_revert(&chgset), "revert failed\n");