diff options
| author | Guixin Liu <kanie@linux.alibaba.com> | 2023-12-31 14:56:44 +0800 |
|---|---|---|
| committer | Keith Busch <kbusch@kernel.org> | 2024-01-03 08:09:39 -0800 |
| commit | ef184b8844bf98a2a80fab8eecda1489aed5d97f (patch) | |
| tree | e7a2f2b026921b1165b381206e93b3fa07eb2185 /drivers/nvme | |
| parent | 75011bd0f9c55db523242f9f9a0b0b826165f14b (diff) | |
| download | lwn-ef184b8844bf98a2a80fab8eecda1489aed5d97f.tar.gz lwn-ef184b8844bf98a2a80fab8eecda1489aed5d97f.zip | |
nvme: tcp: remove unnecessary goto statement
There is no requirement to call nvme_tcp_free_queue() for queue
deallocation if the pskid is null or the queue allocation fails, as
the NVME_TCP_Q_ALLOCATED flag would not be set in such scenarios.
Signed-off-by: Guixin Liu <kanie@linux.alibaba.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/host/tcp.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index d79811cfa0ce..5056bcae2f39 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -1922,14 +1922,13 @@ static int nvme_tcp_alloc_admin_queue(struct nvme_ctrl *ctrl) ctrl->opts->subsysnqn); if (!pskid) { dev_err(ctrl->device, "no valid PSK found\n"); - ret = -ENOKEY; - goto out_free_queue; + return -ENOKEY; } } ret = nvme_tcp_alloc_queue(ctrl, 0, pskid); if (ret) - goto out_free_queue; + return ret; ret = nvme_tcp_alloc_async_req(to_tcp_ctrl(ctrl)); if (ret) |