diff options
| author | Jay Freyensee <james.p.freyensee@intel.com> | 2016-07-20 21:26:16 -0600 |
|---|---|---|
| committer | Jens Axboe <axboe@fb.com> | 2016-07-20 21:26:16 -0600 |
| commit | fa9a89fc6637958594f285c8466422105e86e28c (patch) | |
| tree | 5a5a12753d91cafc099e9cfcf43816a89fddbdcc /drivers/nvme/host | |
| parent | f9cc4472c963e64493261d834155974c48c0ff88 (diff) | |
| download | lwn-fa9a89fc6637958594f285c8466422105e86e28c.tar.gz lwn-fa9a89fc6637958594f285c8466422105e86e28c.zip | |
nvme: initialize variable before logical OR'ing it
It is typically not good coding or secure coding practice
to logical OR a variable without an initialization value first.
Here on this line:
integrity.flags |= BLK_INTEGRITY_DEVICE_CAPABLE;
BLK_INTEGRITY_DEVICE_CAPABLE is being OR'ed to a member variable
never set to an initial value. This patch fixes that.
Signed-off-by: Jay Freyensee <james.p.freyensee@intel.com>
Reviewed-by: Ming Lin <ming.l@samsung.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
Diffstat (limited to 'drivers/nvme/host')
| -rw-r--r-- | drivers/nvme/host/core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c index 9f0ec3b4659f..74b1d380dd42 100644 --- a/drivers/nvme/host/core.c +++ b/drivers/nvme/host/core.c @@ -842,6 +842,7 @@ static void nvme_init_integrity(struct nvme_ns *ns) { struct blk_integrity integrity; + memset(&integrity, 0, sizeof(integrity)); switch (ns->pi_type) { case NVME_NS_DPS_PI_TYPE3: integrity.profile = &t10_pi_type3_crc; |