diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2023-05-16 22:14:09 +0200 |
|---|---|---|
| committer | Dan Williams <dan.j.williams@intel.com> | 2023-06-07 13:30:21 -0700 |
| commit | 7f80ab365a1d10cb143c897954199c760272c338 (patch) | |
| tree | fbf0f70595a56c2cfbac07e173c7e7e16e3264b2 /drivers/nvdimm | |
| parent | 9e46e541cf19fffbbbd9c6ef393446e7d5ef8c39 (diff) | |
| download | lwn-7f80ab365a1d10cb143c897954199c760272c338.tar.gz lwn-7f80ab365a1d10cb143c897954199c760272c338.zip | |
libnvdimm: mark 'security_show' static again
The security_show() function was made global and __weak at some
point to allow overriding it. The override was removed later, but
it remains global, which causes a warning about the missing
declaration:
drivers/nvdimm/dimm_devs.c:352:9: error: no previous prototype for 'security_show'
This is also not an appropriate name for a global symbol in the
kernel, so just make it static again.
Fixes: 15a8348707ff ("libnvdimm: Introduce CONFIG_NVDIMM_SECURITY_TEST flag")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/20230516201415.556858-3-arnd@kernel.org
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/nvdimm')
| -rw-r--r-- | drivers/nvdimm/dimm_devs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c index 957f7c3d17ba..10c3cb6a574a 100644 --- a/drivers/nvdimm/dimm_devs.c +++ b/drivers/nvdimm/dimm_devs.c @@ -349,7 +349,7 @@ static ssize_t available_slots_show(struct device *dev, } static DEVICE_ATTR_RO(available_slots); -ssize_t security_show(struct device *dev, +static ssize_t security_show(struct device *dev, struct device_attribute *attr, char *buf) { struct nvdimm *nvdimm = to_nvdimm(dev); |