diff options
| author | Martin Faltesek <mfaltesek@google.com> | 2022-06-06 21:57:27 -0500 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-08 10:17:17 -0700 |
| commit | 77e5fe8f176a525523ae091d6fd0fbb8834c156d (patch) | |
| tree | 12f7aab6168bf7878f76c717d2484a3a7301acfb /drivers/nfc | |
| parent | 653926f6938d0dbfa44ee66c3d3cf0df3c08b583 (diff) | |
| download | lwn-77e5fe8f176a525523ae091d6fd0fbb8834c156d.tar.gz lwn-77e5fe8f176a525523ae091d6fd0fbb8834c156d.zip | |
nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION
The first validation check for EVT_TRANSACTION has two different checks
tied together with logical AND. One is a check for minimum packet length,
and the other is for a valid aid_tag. If either condition is true (fails),
then an error should be triggered. The fix is to change && to ||.
Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support")
Cc: stable@vger.kernel.org
Signed-off-by: Martin Faltesek <mfaltesek@google.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/nfc')
| -rw-r--r-- | drivers/nfc/st21nfca/se.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/nfc/st21nfca/se.c b/drivers/nfc/st21nfca/se.c index 7e213f8ddc98..9645777f2544 100644 --- a/drivers/nfc/st21nfca/se.c +++ b/drivers/nfc/st21nfca/se.c @@ -315,7 +315,7 @@ int st21nfca_connectivity_event_received(struct nfc_hci_dev *hdev, u8 host, * AID 81 5 to 16 * PARAMETERS 82 0 to 255 */ - if (skb->len < NFC_MIN_AID_LENGTH + 2 && + if (skb->len < NFC_MIN_AID_LENGTH + 2 || skb->data[0] != NFC_EVT_TRANSACTION_AID_TAG) return -EPROTO; |