diff options
| author | Claudiu Manoil <claudiu.manoil@nxp.com> | 2021-09-17 13:22:06 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-19 12:10:26 +0100 |
| commit | 9f7afa05c9522b086327929ae622facab0f0f72b (patch) | |
| tree | 2f406e6d3c57ccc6292200ab610ce836e156f28f /drivers/net | |
| parent | 7237a494decfa17d0b9d0076e6cee3235719de90 (diff) | |
| download | lwn-9f7afa05c9522b086327929ae622facab0f0f72b.tar.gz lwn-9f7afa05c9522b086327929ae622facab0f0f72b.zip | |
enetc: Fix uninitialized struct dim_sample field usage
The only struct dim_sample member that does not get
initialized by dim_update_sample() is comp_ctr. (There
is special API to initialize comp_ctr:
dim_update_sample_with_comps(), and it is currently used
only for RDMA.) comp_ctr is used to compute curr_stats->cmps
and curr_stats->cpe_ratio (see dim_calc_stats()) which in
turn are consumed by the rdma_dim_*() API. Therefore,
functionally, the net_dim*() API consumers are not affected.
Nevertheless, fix the computation of statistics based
on an uninitialized variable, even if the mentioned statistics
are not used at the moment.
Fixes: ae0e6a5d1627 ("enetc: Add adaptive interrupt coalescing")
Signed-off-by: Claudiu Manoil <claudiu.manoil@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/freescale/enetc/enetc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c index 7f90c27c0e79..042327b9981f 100644 --- a/drivers/net/ethernet/freescale/enetc/enetc.c +++ b/drivers/net/ethernet/freescale/enetc/enetc.c @@ -419,7 +419,7 @@ static void enetc_rx_dim_work(struct work_struct *w) static void enetc_rx_net_dim(struct enetc_int_vector *v) { - struct dim_sample dim_sample; + struct dim_sample dim_sample = {}; v->comp_cnt++; |