diff options
| author | Tobias Jungel <tobias.jungel@gmail.com> | 2018-10-28 12:54:10 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-29 20:39:38 -0700 |
| commit | 414dd6fb9a1a1b59983aea7bf0f79f0085ecc5b8 (patch) | |
| tree | c7d8e8df59ca66b115f660a7d59441f39a73c802 /drivers/net | |
| parent | 966c37f2d77eb44d47af8e919267b1ba675b2eca (diff) | |
| download | lwn-414dd6fb9a1a1b59983aea7bf0f79f0085ecc5b8.tar.gz lwn-414dd6fb9a1a1b59983aea7bf0f79f0085ecc5b8.zip | |
bonding: fix length of actor system
The attribute IFLA_BOND_AD_ACTOR_SYSTEM is sent to user space having the
length of sizeof(bond->params.ad_actor_system) which is 8 byte. This
patch aligns the length to ETH_ALEN to have the same MAC address exposed
as using sysfs.
Fixes: f87fda00b6ed2 ("bonding: prevent out of bound accesses")
Signed-off-by: Tobias Jungel <tobias.jungel@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/bonding/bond_netlink.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/bonding/bond_netlink.c b/drivers/net/bonding/bond_netlink.c index 9697977b80f0..6b9ad8673218 100644 --- a/drivers/net/bonding/bond_netlink.c +++ b/drivers/net/bonding/bond_netlink.c @@ -638,8 +638,7 @@ static int bond_fill_info(struct sk_buff *skb, goto nla_put_failure; if (nla_put(skb, IFLA_BOND_AD_ACTOR_SYSTEM, - sizeof(bond->params.ad_actor_system), - &bond->params.ad_actor_system)) + ETH_ALEN, &bond->params.ad_actor_system)) goto nla_put_failure; } if (!bond_3ad_get_active_agg_info(bond, &info)) { |