diff options
| author | Al Viro <viro@ftp.linux.org.uk> | 2007-01-23 12:25:08 +0000 |
|---|---|---|
| committer | Jeff Garzik <jeff@garzik.org> | 2007-01-23 16:26:33 -0500 |
| commit | 3196265e97c661d9e9be04d5d64ca8ff3186536d (patch) | |
| tree | cd99642b956a7d8a16751de28a3c778e291426c2 /drivers/net | |
| parent | 184231bdb41fc4c385ae8e115f5afaff02fe1690 (diff) | |
| download | lwn-3196265e97c661d9e9be04d5d64ca8ff3186536d.tar.gz lwn-3196265e97c661d9e9be04d5d64ca8ff3186536d.zip | |
s2io bogus memset
memset() after kmalloc() on size * 8 would better be on size * 8, not
just size; fixed by switching to kcalloc() - it's more idiomatic anyway.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/s2io.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/s2io.c b/drivers/net/s2io.c index 250cdbeefdfd..1dd66b8ea0fa 100644 --- a/drivers/net/s2io.c +++ b/drivers/net/s2io.c @@ -556,10 +556,9 @@ static int init_shared_mem(struct s2io_nic *nic) } } - nic->ufo_in_band_v = kmalloc((sizeof(u64) * size), GFP_KERNEL); + nic->ufo_in_band_v = kcalloc(size, sizeof(u64), GFP_KERNEL); if (!nic->ufo_in_band_v) return -ENOMEM; - memset(nic->ufo_in_band_v, 0, size); /* Allocation and initialization of RXDs in Rings */ size = 0; |