diff options
| author | bui duc phuc <phucduc.bui@gmail.com> | 2026-08-24 17:09:01 +0700 |
|---|---|---|
| committer | Paolo Abeni <pabeni@redhat.com> | 2026-08-27 10:00:14 +0200 |
| commit | 991c2be78257cba5bf53cf935fe70f8836964288 (patch) | |
| tree | a4468bb76e33cc5f2d03d55c247d3f88e5e0d364 /drivers/net | |
| parent | f967455fb2a5a2079b9eb5823e9ccf359174bf9f (diff) | |
| download | lwn-991c2be78257cba5bf53cf935fe70f8836964288.tar.gz lwn-991c2be78257cba5bf53cf935fe70f8836964288.zip | |
net: ethernet: sun4i-emac: Fix IRQ error handling
irq_of_parse_and_map() returns 0 when parsing or mapping an IRQ fails.
The current code checks for -ENXIO and therefore does not detect the
failure.
Check for a zero return value and convert it to -ENXIO.
Fixes: 492205050d77 ("net: Add EMAC ethernet driver found on Allwinner A10 SoC's")
Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Link: https://patch.msgid.link/20260824100901.31675-1-phucduc.bui@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/allwinner/sun4i-emac.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/allwinner/sun4i-emac.c b/drivers/net/ethernet/allwinner/sun4i-emac.c index 42174249ef61..942454e29488 100644 --- a/drivers/net/ethernet/allwinner/sun4i-emac.c +++ b/drivers/net/ethernet/allwinner/sun4i-emac.c @@ -996,9 +996,9 @@ static int emac_probe(struct platform_device *pdev) /* fill in parameters for net-dev structure */ ndev->base_addr = (unsigned long)db->membase; ndev->irq = irq_of_parse_and_map(np, 0); - if (ndev->irq == -ENXIO) { + if (!ndev->irq) { netdev_err(ndev, "No irq resource\n"); - ret = ndev->irq; + ret = -ENXIO; goto out_iounmap; } |