summaryrefslogtreecommitdiff
path: root/drivers/net/virtio_net.c
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2020-12-04 17:23:16 +0300
committerMichael S. Tsirkin <mst@redhat.com>2020-12-18 16:14:30 -0500
commit411ea23a76526e6efed0b601abb603d3c981b333 (patch)
tree89faf2e463c0b92ca6b9e22765e5fbe02faa0985 /drivers/net/virtio_net.c
parentae93d8ea0fa701e84ab9df0db9fb60ec6c80d7b8 (diff)
downloadlwn-411ea23a76526e6efed0b601abb603d3c981b333.tar.gz
lwn-411ea23a76526e6efed0b601abb603d3c981b333.zip
virtio_net: Fix error code in probe()
Set a negative error code intead of returning success if the MTU has been changed to something invalid. Fixes: fe36cbe0671e ("virtio_net: clear MTU when out of range") Reported-by: Robert Buhren <robert.buhren@sect.tu-berlin.de> Reported-by: Felicitas Hetzelt <file@sect.tu-berlin.de> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/X8pGVJSeeCdII1Ys@mwanda Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'drivers/net/virtio_net.c')
-rw-r--r--drivers/net/virtio_net.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 21b71148c532..34bb95dd9239 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -3072,6 +3072,7 @@ static int virtnet_probe(struct virtio_device *vdev)
dev_err(&vdev->dev,
"device MTU appears to have changed it is now %d < %d",
mtu, dev->min_mtu);
+ err = -EINVAL;
goto free;
}