diff options
| author | David Dillow <dave@thedillows.org> | 2010-10-24 10:20:20 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-24 16:25:40 -0700 |
| commit | 154ccd82e1b871ca012e781e01566128754d8c5f (patch) | |
| tree | ab83e3b253ab7bff71a48e73947a0e8dc881b82a /drivers/net/typhoon.c | |
| parent | 5c398dc8f5a58b5417d8ae0d474704feb6e12a12 (diff) | |
| download | lwn-154ccd82e1b871ca012e781e01566128754d8c5f.tar.gz lwn-154ccd82e1b871ca012e781e01566128754d8c5f.zip | |
typhoon: wait for RX mode commands to finish
When adding VLAN devices, we can get several calls to
typhoon_set_rx_mode() in quick succession. Because we didn't wait for
the commands to complete, we could run out of command descriptors and
fail to set the RX mode.
Signed-off-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/typhoon.c')
| -rw-r--r-- | drivers/net/typhoon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index 1cc67138adbf..5957d4ecd86b 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -936,7 +936,7 @@ typhoon_set_rx_mode(struct net_device *dev) filter |= TYPHOON_RX_FILTER_MCAST_HASH; } - INIT_COMMAND_NO_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); + INIT_COMMAND_WITH_RESPONSE(&xp_cmd, TYPHOON_CMD_SET_RX_FILTER); xp_cmd.parm1 = filter; typhoon_issue_command(tp, 1, &xp_cmd, 0, NULL); } |