diff options
| author | Julia Lawall <julia@diku.dk> | 2010-10-26 00:25:36 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-27 12:23:20 -0700 |
| commit | 13c3ab86f27967488b8182a173ebc899c9111bf0 (patch) | |
| tree | 1bcfa9b90c9226fc04d12d5863c829858dd9466f /drivers/net/typhoon.c | |
| parent | d58c0e95622c0de271ae57c083ad25ff4eb032c8 (diff) | |
| download | lwn-13c3ab86f27967488b8182a173ebc899c9111bf0.tar.gz lwn-13c3ab86f27967488b8182a173ebc899c9111bf0.zip | |
drivers/net/typhoon.c: delete double assignment
Delete successive assignments to the same location. The current definition
does not initialize the respRing structure, which has the same type as the
cmdRing structure, so initialize that one instead.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression i;
@@
*i = ...;
i = ...;
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: David Dillow <dave@thedillows.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/typhoon.c')
| -rw-r--r-- | drivers/net/typhoon.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c index b550da008a03..5b83c3f35f47 100644 --- a/drivers/net/typhoon.c +++ b/drivers/net/typhoon.c @@ -1300,7 +1300,7 @@ typhoon_init_rings(struct typhoon *tp) tp->rxHiRing.lastWrite = 0; tp->rxBuffRing.lastWrite = 0; tp->cmdRing.lastWrite = 0; - tp->cmdRing.lastWrite = 0; + tp->respRing.lastWrite = 0; tp->txLoRing.lastRead = 0; tp->txHiRing.lastRead = 0; |