diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2006-01-30 11:37:55 -0800 |
|---|---|---|
| committer | Jeff Garzik <jgarzik@pobox.com> | 2006-02-07 02:00:35 -0500 |
| commit | 2d42d21f11c20b94ea0222637e20e2630845afe4 (patch) | |
| tree | ed740ea45977801bb9017291449a8c8fa57bb4fe /drivers/net/sky2.h | |
| parent | 08c06d8a9063c81f6a21c9f275aa1ee49d4bf380 (diff) | |
| download | lwn-2d42d21f11c20b94ea0222637e20e2630845afe4.tar.gz lwn-2d42d21f11c20b94ea0222637e20e2630845afe4.zip | |
[PATCH] sky2: pci config space checking
There were bugs in mmconfig access to PCI space, up to and
include 2.6.16-rc1. These prevented the sky2 driver from being
able to clear PCI express errors.
This patch makes the driver check (during probe), for errors
in PCI config access and fail.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
Diffstat (limited to 'drivers/net/sky2.h')
| -rw-r--r-- | drivers/net/sky2.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/drivers/net/sky2.h b/drivers/net/sky2.h index 95518921001c..70525ac501de 100644 --- a/drivers/net/sky2.h +++ b/drivers/net/sky2.h @@ -1867,14 +1867,6 @@ static inline u8 sky2_read8(const struct sky2_hw *hw, unsigned reg) return readb(hw->regs + reg); } -/* This should probably go away, bus based tweeks suck */ -static inline int is_pciex(const struct sky2_hw *hw) -{ - u32 status; - pci_read_config_dword(hw->pdev, PCI_DEV_STATUS, &status); - return (status & PCI_OS_PCI_X) == 0; -} - static inline void sky2_write32(const struct sky2_hw *hw, unsigned reg, u32 val) { writel(val, hw->regs + reg); |