diff options
| author | Francois Romieu <romieu@fr.zoreil.com> | 2011-08-25 18:47:24 +0200 |
|---|---|---|
| committer | Francois Romieu <romieu@fr.zoreil.com> | 2011-09-17 11:38:05 +0200 |
| commit | e03f33af79f0772156e1a1a1e36bdddf8012b2e4 (patch) | |
| tree | 4af8610b530f3eae7daedbc7f78c9b6e679bc9d4 /drivers/net/r8169.c | |
| parent | 106633897e086e1b47126996aac1a427eb80eb1b (diff) | |
| download | lwn-e03f33af79f0772156e1a1a1e36bdddf8012b2e4.tar.gz lwn-e03f33af79f0772156e1a1a1e36bdddf8012b2e4.zip | |
r8169: remove erroneous processing of always set bit.
When set, RxFOVF (resp. RxBOVF) is always 1 (resp. 0).
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Cc: Hayes <hayeswang@realtek.com>
Diffstat (limited to 'drivers/net/r8169.c')
| -rw-r--r-- | drivers/net/r8169.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index 78c1d5832792..dff0bf094168 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -407,6 +407,7 @@ enum rtl_register_content { RxOK = 0x0001, /* RxStatusDesc */ + RxBOVF = (1 << 24), RxFOVF = (1 << 23), RxRWT = (1 << 22), RxRES = (1 << 21), @@ -682,6 +683,7 @@ struct rtl8169_private { struct mii_if_info mii; struct rtl8169_counters counters; u32 saved_wolopts; + u32 opts1_mask; struct rtl_fw { const struct firmware *fw; @@ -3786,6 +3788,9 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) tp->intr_event = cfg->intr_event; tp->napi_event = cfg->napi_event; + tp->opts1_mask = (tp->mac_version != RTL_GIGA_MAC_VER_01) ? + ~(RxBOVF | RxFOVF) : ~0; + init_timer(&tp->timer); tp->timer.data = (unsigned long) dev; tp->timer.function = rtl8169_phy_timer; @@ -5324,7 +5329,7 @@ static int rtl8169_rx_interrupt(struct net_device *dev, u32 status; rmb(); - status = le32_to_cpu(desc->opts1); + status = le32_to_cpu(desc->opts1) & tp->opts1_mask; if (status & DescOwn) break; |