diff options
| author | Rami Rosen <ramirose@gmail.com> | 2010-06-03 05:02:29 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-06-05 02:23:15 -0700 |
| commit | 55c95e738da85373965cb03b4f975d0fd559865b (patch) | |
| tree | dc3fe475c410606c2ce9cb43fcd204fcec805975 /drivers/net/pppoe.c | |
| parent | 5918e2fb9035b35164002c3a268feaf70b7c04d5 (diff) | |
| download | lwn-55c95e738da85373965cb03b4f975d0fd559865b.tar.gz lwn-55c95e738da85373965cb03b4f975d0fd559865b.zip | |
fix return value of __pppoe_xmit() method.
Hi,
__pppoe_xmit() in drivers/net/pppoe always returns 1.
When the methods fails (via goto abort), it should return 0 and not 1.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/pppoe.c')
| -rw-r--r-- | drivers/net/pppoe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/pppoe.c b/drivers/net/pppoe.c index 805b64d1e893..7ebb8e87efa4 100644 --- a/drivers/net/pppoe.c +++ b/drivers/net/pppoe.c @@ -949,7 +949,7 @@ static int __pppoe_xmit(struct sock *sk, struct sk_buff *skb) abort: kfree_skb(skb); - return 1; + return 0; } /************************************************************************ |